![]() Usually it makes sense to file a JIRA issue first, and then create a PR with description Hadoop issue handles must in the form `HADOOP-YYYYY` (all capitals). Comments and PRs with Hadoop issue handles should post to mailing lists and Jira. If you are a committer and don't have the privilege, you need to link your ASF and GitHub account via Apache/github integration features Now Hadoop committer can directly close GitHub pull requests. Closing a PR without committing (for committers) Anyway, watch for dupe PRs (based on same source branches). ![]() This is more important for contributors to know, rather than for committers, because if new PR is not mergeable, github would warn to begin with. The workflow implies that every new PR starts with a new rebased branch. Note on squashing: Since squash discards remote branch history, repeated PRs from the same remote branch are difficult for merging. Merging pull requests are equivalent to a "pull" of a contributor's branch: In order to do that, as well as close the PR at the same time, it is recommended to use squash commits. In this case it is recommended to squash remote commit history to have one commit per issue, rather than merging in a multitude of contributor's commits. Remember that pull requests are equivalent to a remote GitHub branch with potentially a multitude of commits. When you need to commit the change locally and push them, start with reading. You can add "Signed-off-by", "Reviewed-by", and "Co-authored-by" when merging the commit. Before merging the PR, the committer must check the title and the commit message, and fix them if needed. In most cases, clicking the "Squash and merge button" is fine. If you are not committer, please create an empty commit on your branch. If there is no such job, click "Scan Repository Now" to scan the pull requests. If you are a committer and want to run Jenkins precommit job manually, log in to and run the job corresponding with the pull request ID. The precommit job is run automatically when opened a PR and when there is any change in your branch. How to run Jenkins precommit job for a PR From now on the PR lives on github's apache/hadoop repository.This will connect the comments of the PR to the mailing list and Jira comments. Click the "Create pull request" button and name the request "HADOOP-XXXX" all caps.The "head fork" will be your forked repo and the "compare" will be your `feature/hadoop-xxxx` branch. Don't submit a PR to one of the other branches unless you know what you are doing. The "base fork" should be apache/hadoop unless you are collaborating separately with one of the committers on the list. ![]() You can edit the to and from for the PR if it isn't correct.Click the green " Compare, review, and create pull request" button.Since you forked it from Github's apache/hadoop it will default any PR to go to apache/trunk. Go to your feature/hadoop-xxxx branch on Github.Git rebase apache/trunk # to make it apply to the current trunk ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |